Skip to content
Snippets Groups Projects
  1. Apr 20, 2022
  2. Apr 11, 2022
    • Patrick Cloke's avatar
      4586119f
    • David Robertson's avatar
      Disallow untyped defs in synapse._scripts (#12422) · 961ee75a
      David Robertson authored
      Of note: 
      
      * No untyped defs in `register_new_matrix_user`
      
      This one might be contraversial. `request_registration` has three
      dependency-injection arguments used for testing. I'm removing the
      injection of the `requests` module and using `unitest.mock.patch` in the
      test cases instead.
      
      Doing `reveal_type(requests)` and `reveal_type(requests.get)` before the
      change:
      
      ```
      synapse/_scripts/register_new_matrix_user.py:45: note: Revealed type is "Any"
      synapse/_scripts/register_new_matrix_user.py:46: note: Revealed type is "Any"
      ```
      
      And after:
      
      ```
      synapse/_scripts/register_new_matrix_user.py:44: note: Revealed type is "types.ModuleType"
      synapse/_scripts/register_new_matrix_user.py:45: note: Revealed type is "def (url: Union[builtins.str, builtins.bytes], params: Union[Union[_typeshed.SupportsItems[Union[builtins.str, builtins.bytes, builtins.int, builtins.float], Union[builtins.str, builtins.bytes, builtins.int, builtins.float, typing.Iterable[Union[builtins.str, builtins.bytes, builtins.int, builtins.float]], None]], Tuple[Union[builtins.str, builtins.bytes, builtins.int, builtins.float], Union[builtins.str, builtins.bytes, builtins.int, builtins.float, typing.Iterable[Union[builtins.str, builtins.bytes, builtins.int, builtins.float]], None]], typing.Iterable[Tuple[Union[builtins.str, builtins.bytes, builtins.int, builtins.float], Union[builtins.str, builtins.bytes, builtins.int, builtins.float, typing.Iterable[Union[builtins.str, builtins.bytes, builtins.int, builtins.float]], None]]], builtins.str, builtins.bytes], None] =, data: Union[Any, None] =, headers: Union[Any, None] =, cookies: Union[Any, None] =, files: Union[Any, None] =, auth: Union[Any, None] =, timeout: Union[Any, None] =, allow_redirects: builtins.bool =, proxies: Union[Any, None] =, hooks: Union[Any, None] =, stream: Union[Any, None] =, verify: Union[Any, None] =, cert: Union[Any, None] =, json: Union[Any, None] =) -> requests.models.Response"
      ```
      
      * Drive-by comment in `synapse.storage.types`
      
      * No untyped defs in `synapse_port_db`
      
      This was by far the most painful. I'm happy to break this up into
      smaller pieces for review if it's not managable as-is.
      961ee75a
  3. Apr 08, 2022
  4. Apr 05, 2022
  5. Apr 03, 2022
  6. Apr 01, 2022
  7. Mar 31, 2022
  8. Mar 29, 2022
  9. Mar 28, 2022
  10. Mar 21, 2022
  11. Mar 18, 2022
  12. Mar 17, 2022
  13. Mar 15, 2022
  14. Mar 11, 2022
  15. Mar 08, 2022
  16. Mar 03, 2022
  17. Mar 02, 2022
  18. Feb 28, 2022
  19. Feb 21, 2022
  20. Feb 11, 2022
  21. Feb 08, 2022
  22. Jan 31, 2022
  23. Dec 30, 2021
  24. Dec 29, 2021
  25. Dec 21, 2021
  26. Dec 20, 2021
  27. Dec 16, 2021
  28. Dec 15, 2021
  29. Dec 14, 2021
Loading