Use $(...) notation instead of legacy backticked `...`.

https://github.com/koalaman/shellcheck/wiki/SC2006



Signed-off-by: Dan Callahan <danc@element.io>

Double quote to prevent globbing and word splitting.

https://github.com/koalaman/shellcheck/wiki/SC2086



Signed-off-by: Dan Callahan <danc@element.io>

var is referenced but not assigned.

https://github.com/koalaman/shellcheck/wiki/SC2154



Signed-off-by: Dan Callahan <danc@element.io>

This is part of fixing #6116: we want to put RC debs into a different place than release debs, so reprepro has to be able to tell them apart.

On NixOS, `bash` isn't under `/bin/bash` but rather in some directory in `$PATH`. Locally, I've been patching those scripts to make them work.

`/usr/bin/env` seems to be the only [portable way](https://unix.stackexchange.com/questions/29608/why-is-it-better-to-use-usr-bin-env-name-instead-of-path-to-name-as-my

) to use binaries from the PATH as interpreters.

Signed-off-by: Quentin Gliech <quentingliech@gmail.com>

* Fix debian packages for sid being called buster.

I don't know why the sid images return buster as its codename in
`lsb_release` but it does, so lets just grab the codename from the
distro we pass into dockerfile

* Newsfile

since #4298, the optional dependencies are no longer installed with a simple
`pip install .`, which meant that they were not being included in the debian
package.

The easy fix to that is dh_virtualenv --extras, but that needs dh_virtualenv
1.1...