Signed-off-by: Sean Quah <seanq@matrix.org>

Signed-off-by: Sean Quah <seanq@matrix.org>

Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>

While the query was fast, we were calling it *a lot*.

event_edges.room_id is implied by the event id, so there is no need to join on the room id.

Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>

This reverts commit e0fae823.

`M_` is a reserved namespace.

Signed-off-by: Jacek Kusnierz <jacek.kusnierz@tum.de>

Uniformize spam-checker API, part 3: Expand check_event_for_spam with the ability to return additional fields (#12846)

Signed-off-by: David Teller <davidt@element.io>

Co-authored-by: Sean Quah <8349537+squahtx@users.noreply.github.com>

Signed-off-by: Nicolas Werner <nicolas.werner@hotmail.de>
Co-authored-by: Brendan Abolivier <github@brendanabolivier.com>

This method was introduced in #12852. It is using the `state_key` column from
the `events` table, which is not (yet) reliable (see #11496).

Signed-off-by: Sumner Evans <sumner@beeper.com>

Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>

Signed-off-by: David Teller <davidt@element.io>
Co-authored-by: Brendan Abolivier <babolivier@matrix.org>

* Properly marks private methods as private.
* Adds missing docstrings.
* Rework inline methods.

Instead of hard-coding strings in many places.

Synapse 1.60.0rc2 (2022-05-27)
==============================

This release of Synapse adds a unique index to the `state_group_edges` table, in
order to prevent accidentally introducing duplicate information (for example,
because a database backup was restored multiple times). If your Synapse database
already has duplicate rows in this table, this could fail with an error and
require manual remediation.

Additionally, the signature of the `check_event_for_spam` module callback has changed.
The previous signature has been deprecated and remains working for now. Module authors
should update their modules to use the new signature where possible.

See [the upgrade notes](https://github.com/matrix-org/synapse/blob/develop/docs/upgrade.md#upgrading-to-v1600)
for more details.

Features
--------

- Add an option allowing users to use their password to reauthenticate for privileged actions even though password login is disabled. ([\#12883](https://github.com/matrix-org/synapse/issues/12883))

Bugfixes
--------

- Explicitly close `ijson` coroutines once we are done with them, instead of leaving the garbage collector to close them. ([\#12875](https://github.com/matrix-org/synapse/issues/12875))

Internal Changes
----------------

- Improve URL previews by not including the content of media tags in the generated description. ([\#12887](https://github.com/matrix-org/synapse/issues/12887))

Hopefully this means that exceptions raised due to truncated JSON
get a sensible logging context and stack.

Signed-off-by: Sean Quah <seanq@matrix.org>

Add an option allowing users to use their password to reauthenticate even though password authentication is disabled. (#12883)