Skip to content
Snippets Groups Projects
Unverified Commit f78b68a9 authored by Hillery Shay's avatar Hillery Shay Committed by GitHub
Browse files

Treat "\u0000" as "\u0020" for the purposes of message search (message indexing) (#10820)


* add test to check if null code points are being inserted

* add logic to detect and replace null code points before insertion into db

* lints

* add license to test

* change approach to null substitution

* add type hint for SearchEntry

* Add changelog entry

Signed-off-by: default avatarH.Shay <shaysquared@gmail.com>

* updated changelog

* update chanelog message

* remove duplicate changelog

* Update synapse/storage/databases/main/events.py remove extra space

Co-authored-by: default avatarPatrick Cloke <clokep@users.noreply.github.com>

* rename and move test file, update tests, delete old test file

* fix typo in comments

* update _find_highlights_in_postgres to replace null byte with space

* replace null byte in sqlite search insertion

* beef up and reorganize test for this pr

* update changelog

* add type hints and update docstring

* check db engine directly vs using env variable

* refactor tests to be less repetetive

* move rplace logic into seperate function

* requested changes

* Fix typo.

* Update synapse/storage/databases/main/search.py

Co-authored-by: default avatarreivilibre <olivier@librepush.net>

* Update changelog.d/10820.misc

Co-authored-by: default avatarAaron Raimist <aaron@raim.ist>

Co-authored-by: default avatarPatrick Cloke <clokep@users.noreply.github.com>
Co-authored-by: default avatarreivilibre <olivier@librepush.net>
Co-authored-by: default avatarAaron Raimist <aaron@raim.ist>
parent 03db6701
No related branches found
No related tags found
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment