Skip to content
Snippets Groups Projects
Unverified Commit cf66d712 authored by Sean Quah's avatar Sean Quah Committed by GitHub
Browse files

Fix initialization of `_device_list_id_gen` (#14914)


On startup, the `_device_list_id_gen` stream id generator is initialized
using the maximum stream id seen in a list of tables. When we started
populating the `device_list_remote_pending` table in #13913, we forgot
to add it to the aforementioned list of tables, so the stream id
generator can hand out old stream ids after a restart. The end result is
that Synapse can fail to handle device list update EDUs after a restart
when a partial state join is in progress.

Add the `device_list_remote_pending` table to the list of tables to
consider when initializing the `_device_list_id_gen` stream id generator.

Signed-off-by: default avatarSean Quah <seanq@matrix.org>
parent f51035bc
No related branches found
No related tags found
No related merge requests found
Faster joins: Fix a bug introduced in Synapse 1.69 where device list EDUs could fail to be handled after a restart when a faster join sync is in progress.
...@@ -99,6 +99,7 @@ class DeviceWorkerStore(RoomMemberWorkerStore, EndToEndKeyWorkerStore): ...@@ -99,6 +99,7 @@ class DeviceWorkerStore(RoomMemberWorkerStore, EndToEndKeyWorkerStore):
("user_signature_stream", "stream_id"), ("user_signature_stream", "stream_id"),
("device_lists_outbound_pokes", "stream_id"), ("device_lists_outbound_pokes", "stream_id"),
("device_lists_changes_in_room", "stream_id"), ("device_lists_changes_in_room", "stream_id"),
("device_lists_remote_pending", "stream_id"),
], ],
is_writer=hs.config.worker.worker_app is None, is_writer=hs.config.worker.worker_app is None,
) )
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment