Fix not sending events over federation when using sharded event persisters (#8536)
* Fix outbound federaion with multiple event persisters. We incorrectly notified federation senders that the minimum persisted stream position had advanced when we got an `RDATA` from an event persister. Notifying of federation senders already correctly happens in the notifier, so we just delete the offending line. * Change some interfaces to use RoomStreamToken. By enforcing use of `RoomStreamTokens` we make it less likely that people pass in random ints that they got from somewhere random.
Showing
- changelog.d/8536.bugfix 1 addition, 0 deletionschangelog.d/8536.bugfix
- synapse/app/generic_worker.py 0 additions, 4 deletionssynapse/app/generic_worker.py
- synapse/federation/send_queue.py 1 addition, 1 deletionsynapse/federation/send_queue.py
- synapse/federation/sender/__init__.py 7 additions, 2 deletionssynapse/federation/sender/__init__.py
- synapse/handlers/appservice.py 7 additions, 4 deletionssynapse/handlers/appservice.py
- synapse/notifier.py 3 additions, 3 deletionssynapse/notifier.py
- synapse/push/emailpusher.py 7 additions, 1 deletionsynapse/push/emailpusher.py
- synapse/push/httppusher.py 7 additions, 1 deletionsynapse/push/httppusher.py
- synapse/push/pusherpool.py 8 additions, 2 deletionssynapse/push/pusherpool.py
- tests/handlers/test_appservice.py 10 additions, 3 deletionstests/handlers/test_appservice.py
Loading
Please register or sign in to comment