Skip to content
Snippets Groups Projects
Commit 81d49cbb authored by Richard van der Hoff's avatar Richard van der Hoff
Browse files

Fix exception when OpenGraph tag values are ints

parent e78167c9
No related branches found
No related tags found
No related merge requests found
Limit the length of data returned by url previews, to prevent DoS attacks.
......@@ -274,7 +274,8 @@ class PreviewUrlResource(DirectServeResource):
# filter out any stupidly long values
keys_to_remove = []
for k, v in og.items():
if len(k) > OG_TAG_NAME_MAXLEN or len(v) > OG_TAG_VALUE_MAXLEN:
# values can be numeric as well as strings, hence the cast to str
if len(k) > OG_TAG_NAME_MAXLEN or len(str(v)) > OG_TAG_VALUE_MAXLEN:
logger.warning(
"Pruning overlong tag %s from OG data", k[:OG_TAG_NAME_MAXLEN]
)
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment