Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
synapse
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Package Registry
Container Registry
Model registry
Operate
Terraform modules
Monitor
Service Desk
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Timo Ley
synapse
Commits
6d89f123
Unverified
Commit
6d89f123
authored
2 years ago
by
David Robertson
Committed by
GitHub
2 years ago
Browse files
Options
Downloads
Patches
Plain Diff
Comment out dodgy log-kv (#12554)
parent
c48ab373
No related branches found
Branches containing commit
No related tags found
Tags containing commit
No related merge requests found
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
changelog.d/12554.bugfix
+1
-0
1 addition, 0 deletions
changelog.d/12554.bugfix
synapse/handlers/device.py
+6
-3
6 additions, 3 deletions
synapse/handlers/device.py
with
7 additions
and
3 deletions
changelog.d/12554.bugfix
0 → 100644
+
1
−
0
View file @
6d89f123
Fix a bug introduced in Synapse 1.58.0rc1 where the main process could consume excessive amounts of CPU and memory handling sentry logging failures.
This diff is collapsed.
Click to expand it.
synapse/handlers/device.py
+
6
−
3
View file @
6d89f123
...
...
@@ -683,9 +683,12 @@ class DeviceHandler(DeviceWorkerHandler):
self
.
federation_sender
.
send_device_messages
(
host
,
immediate
=
False
)
log_kv
(
{
"
message
"
:
"
sent device update to host
"
,
"
host
"
:
host
}
)
# TODO: when called, this isn't in a logging context.
# This leads to log spam, sentry event spam, and massive
# memory usage. See #12552.
# log_kv(
# {"message": "sent device update to host", "host": host}
# )
if
current_stream_id
!=
stream_id
:
# Clear the set of hosts we've already sent to as we're
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment