Skip to content
Snippets Groups Projects
Unverified Commit 2c240213 authored by Lukas Lihotzki's avatar Lukas Lihotzki Committed by GitHub
Browse files

Fix requestOpenIdToken response: integer expires_in (#10175)

`expires_in` must be an integer according to the OpenAPI spec:
https://github.com/matrix-org/matrix-doc/blob/master/data/api/client-server/definitions/openid_token.yaml#L32



True division (`/`) returns a float instead (`"expires_in": 3600.0`).
Floor division (`//`) returns an integer, so the response is spec compliant.

Signed-off-by: default avatarLukas Lihotzki <lukas@lihotzki.de>
parent 0adc2882
No related branches found
No related tags found
No related merge requests found
Fix a minor bug in the response to `/_matrix/client/r0/user/{user}/openid/request_token`. Contributed by @lukaslihotzki.
...@@ -85,7 +85,7 @@ class IdTokenServlet(RestServlet): ...@@ -85,7 +85,7 @@ class IdTokenServlet(RestServlet):
"access_token": token, "access_token": token,
"token_type": "Bearer", "token_type": "Bearer",
"matrix_server_name": self.server_name, "matrix_server_name": self.server_name,
"expires_in": self.EXPIRES_MS / 1000, "expires_in": self.EXPIRES_MS // 1000,
}, },
) )
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment