-
- Downloads
Merge pull request from GHSA-x345-32rc-8h85
* tests for push rule pattern matching * tests for acl pattern matching * factor out common `re.escape` * Factor out common re.compile * Factor out common anchoring code * add word_boundary support to `glob_to_regex` * Use `glob_to_regex` in push rule evaluator NB that this drops support for character classes. I don't think anyone ever used them. * Improve efficiency of globs with multiple wildcards The idea here is that we compress multiple `*` globs into a single `.*`. We also need to consider `?`, since `*?*` is as hard to implement efficiently as `**`. * add assertion on regex pattern * Fix mypy * Simplify glob_to_regex * Inline the glob_to_regex helper function Signed-off-by:Dan Callahan <danc@element.io> * Moar comments Signed-off-by:
Dan Callahan <danc@element.io> Co-authored-by:
Dan Callahan <danc@element.io>
Showing
- synapse/config/tls.py 2 additions, 2 deletionssynapse/config/tls.py
- synapse/push/push_rule_evaluator.py 3 additions, 52 deletionssynapse/push/push_rule_evaluator.py
- synapse/util/__init__.py 47 additions, 14 deletionssynapse/util/__init__.py
- tests/federation/test_federation_server.py 19 additions, 0 deletionstests/federation/test_federation_server.py
- tests/push/test_push_rule_evaluator.py 166 additions, 0 deletionstests/push/test_push_rule_evaluator.py
- tests/util/test_glob_to_regex.py 59 additions, 0 deletionstests/util/test_glob_to_regex.py
Loading
Please register or sign in to comment