Skip to content
Snippets Groups Projects
Forked from Maunium / synapse
Source project has a limited visibility.
  • 14mRh4X0r's avatar
    8942e23a
    Always update AS last_pos, even on no events (#10107) · 8942e23a
    14mRh4X0r authored
    
    Fixes #1834.
    
    `get_new_events_for_appservice` internally calls `get_events_as_list`, which will filter out any rejected events. If all returned events are filtered out, `_notify_interested_services` will return without updating the last handled stream position. If there are 100 consecutive such events, processing will halt altogether.
    
    Breaking the loop is now done by checking whether we're up-to-date with `current_max` in the loop condition, instead of relying on an empty `events` list.
    
    
    Signed-off-by: default avatarWillem Mulder <14mRh4X0r@gmail.com>
    8942e23a
    History
    Always update AS last_pos, even on no events (#10107)
    14mRh4X0r authored
    
    Fixes #1834.
    
    `get_new_events_for_appservice` internally calls `get_events_as_list`, which will filter out any rejected events. If all returned events are filtered out, `_notify_interested_services` will return without updating the last handled stream position. If there are 100 consecutive such events, processing will halt altogether.
    
    Breaking the loop is now done by checking whether we're up-to-date with `current_max` in the loop condition, instead of relying on an empty `events` list.
    
    
    Signed-off-by: default avatarWillem Mulder <14mRh4X0r@gmail.com>