Skip to content
Snippets Groups Projects
Forked from Maunium / synapse
Source project has a limited visibility.
  • Richard van der Hoff's avatar
    2ec8ca5e
    Remove SynapseRequest.get_user_agent (#9069) · 2ec8ca5e
    Richard van der Hoff authored
    SynapseRequest is in danger of becoming a bit of a dumping-ground for "useful stuff relating to Requests",
    which isn't really its intention (its purpose is to override render, finished and connectionLost to set up the 
    LoggingContext and write the right entries to the request log).
    
    Putting utility functions inside SynapseRequest means that lots of our code ends up requiring a
    SynapseRequest when there is nothing synapse-specific about the Request at all, and any old
    twisted.web.iweb.IRequest will do. This increases code coupling and makes testing more difficult.
    
    In short: move get_user_agent out to a utility function.
    Remove SynapseRequest.get_user_agent (#9069)
    Richard van der Hoff authored
    SynapseRequest is in danger of becoming a bit of a dumping-ground for "useful stuff relating to Requests",
    which isn't really its intention (its purpose is to override render, finished and connectionLost to set up the 
    LoggingContext and write the right entries to the request log).
    
    Putting utility functions inside SynapseRequest means that lots of our code ends up requiring a
    SynapseRequest when there is nothing synapse-specific about the Request at all, and any old
    twisted.web.iweb.IRequest will do. This increases code coupling and makes testing more difficult.
    
    In short: move get_user_agent out to a utility function.