- May 26, 2024
-
-
Signed-off-by:strawberry <strawberry@puppygock.gay>
-
this is normal redactions. no valid reason this needs to be warn as it just causes confusion. Signed-off-by: -
Signed-off-by: -
only enabled if federation is enabled Signed-off-by: -
Signed-off-by: -
for a very long time, if a remote server responded to us with a valid but unsuccessful (HTTP 4xx) response and the caller was the `send_federation_request` function, we may find ourselves with a warning message only containing the destination's server name which was very unhelpful. the true error was buried away in trace logs. this would primarily be noticed with server key fetch requests from us. conduit has been throwing away the ruma request error: https://gitlab.com/famedly/conduit/-/blame/next/src/utils/error.rs#L62 before: 2024-05-23T04:45:02.930224Z WARN router:{path=/_matrix/client/v3/publicRooms}:handle: conduit_api::client_server::directory: Failed to return our /publicRooms: matrix.org after: 2024-05-23T05:05:02.435272Z WARN router:{path=/_matrix/client/v3/publicRooms}:handle: conduit_api::client_server::directory: Failed to return our /publicRooms: matrix.org: [401 / M_UNAUTHORIZED] Failed to find any key to satisfy: _FetchKeyRequest(server_name='your.server.name', minimum_valid_until_ts=1716440702337, key_ids=['ed25519:RQB3XPQX']) Signed-off-by:
-
Signed-off-by: -
Signed-off-by: -
wow this was terrible, early strawberry code Signed-off-by: -
Signed-off-by: -
Signed-off-by: -
this matrix-react-sdk PR (and the cited sliding sync MSC) says that they will intend on checking sliding sync support from this unstable feature flag at /versions until the CORS header stuff is specced https://github.com/matrix-org/matrix-react-sdk/pull/12498 Signed-off-by:
-
• Updated input 'rocksdb': 'github:girlbossceo/rocksdb/db6df0b185774778457dabfcbd822cb81760cade' (2024-05-03) → 'github:girlbossceo/rocksdb/be68b3c95ccd225f3121ba33a67cfaf3c3596afc' (2024-05-23) Signed-off-by: -
Signed-off-by: -
Signed-off-by: -
Signed-off-by: -
CI jemalloc is now a default feature Signed-off-by: -
Signed-off-by: -
• Updated input 'crane': 'github:ipetkov/crane/27025ab71bdca30e7ed0a16c88fd74c5970fc7f5' (2024-05-09) → 'github:ipetkov/crane/7443df1c478947bf96a2e699209f53b2db26209d' (2024-05-19) • Updated input 'fenix': 'github:nix-community/fenix/297c756ba6249d483c1dafe42378560458842173' (2024-05-10) → 'github:nix-community/fenix/063d7e5fac454edd35b7e2cedb6ca9fb1410c79b' (2024-05-21) • Updated input 'fenix/rust-analyzer-src': 'github:rust-lang/rust-analyzer/5bf2f85c8054d80424899fa581db1b192230efb5' (2024-05-09) → 'github:rust-lang/rust-analyzer/21ec8f523812b88418b2bfc64240c62b3dd967bd' (2024-05-19) • Updated input 'nixpkgs': 'github:NixOS/nixpkgs/f1010e0469db743d14519a1efd37e23f8513d714' (2024-05-09) → 'github:NixOS/nixpkgs/3eaeaeb6b1e08a016380c279f8846e0bd8808916' (2024-05-21) Signed-off-by: -
jq input change was from https://gitlab.computer.surgery/matrix/grapevine-fork/-/commit/17eb3545906d21f2ed18f0f0f917a4638f12ef6c to prevent unnecessary bindgen rebuilds Signed-off-by:
-
Signed-off-by:
-
- May 24, 2024
-
-
Signed-off-by: -
-
Not sure what changed that we need this Signed-off-by:morguldir <morguldir@protonmail.com>
-
Signed-off-by: -
With: strings /nix/store/9skicdac6xs4yww1nd3h7m6xydv4hxlj-rocksdb-9.1.1/lib/librocksdb.so.9|rg io_uring|wc -l 112 With: strings result/bin/conduit |rg io_uring|wc -l 5 Without: strings static-x86_64-unknown-linux-musl-jemalloc |rg io_uring | wc -l 0 Signed-off-by: -
Previously we were relying on NIX_CFLAGS_COMPILE, but this is not being set in static devshells. A cleaner solution for complement would likely be to build the tests in their own nix derivation instead of building them in the devshell, but this change unblocks CI for now.
-
Dynamically-linked jemalloc is broken.
-
This is broken on linux, but can be used by darwin users for development, since static/jemalloc/darwin is broken.
-
-
-
This is causing build failures on Mac: > In file included from /tmp/nix-build-rocksdb-static-aarch64-apple-darwin-9.1.1.drv-0/source/memory/memory_allocator.cc:8: > In file included from /tmp/nix-build-rocksdb-static-aarch64-apple-darwin-9.1.1.drv-0/source/memory/jemalloc_nodump_allocator.h:11: > /tmp/nix-build-rocksdb-static-aarch64-apple-darwin-9.1.1.drv-0/source/port/jemalloc_helper.h:63:36: warning: unknown attribute '_rjem_malloc' ignored [-Wunknown-attributes] > mallocx(size_t, int) JEMALLOC_ATTR(malloc) JEMALLOC_ALLOC_SIZE(1) > ^~~~~~ > /nix/store/3bix0kzy670dyhhizri3dwb1qfj3sdpa-jemalloc-static-aarch64-apple-darwin-5.3.0/include/jemalloc/jemalloc.h:412:18: note: expanded from macro 'malloc' > # define malloc je_malloc > ^~~~~~~~~ > /nix/store/3bix0kzy670dyhhizri3dwb1qfj3sdpa-jemalloc-static-aarch64-apple-darwin-5.3.0/include/jemalloc/jemalloc.h:75:21: note: expanded from macro 'je_malloc' > # define je_malloc _rjem_malloc > ^~~~~~~~~~~~ > /nix/store/3bix0kzy670dyhhizri3dwb1qfj3sdpa-jemalloc-static-aarch64-apple-darwin-5.3.0/include/jemalloc/jemalloc.h:183:43: note: expanded from macro 'JEMALLOC_ATTR' > # define JEMALLOC_ATTR(s) __attribute__((s)) Full build log at <https://girlboss.ceo/~strawberry/pb/ygJ3>. This is likely fixable with patches to rocksdb, but not worth it since darwin is only a dev platform.
-
-
-
CI is running `cargo build --all-features`, so we should be passing all the features to nix as well. The only thing this currently affects is the jemalloc_prof feature, but if we add any non-default features that affect nix in the future they should also be handled correctly now.
-
Dynamically-linked jemalloc doesn't work due to link-order issues, and we want CI to be testing a static binary anyway since that's what we're publishing in releases.
-
We're planning to add a second devshell with `all-features` for CI.
-
This doesn't seem to be necessary to build, and the derivation is broken in pkgsStatic.
-
Some of the features affect nix dependencies, so we need to have a full feature list available when constructing the nix derivation. This incidentally fixes the bug where we weren't enabling jemalloc on rocksdb in CI/devshells, because jemalloc is now a default feature. It does not fix the more general class of that issue, where CI is performing an `--all-features` build in a nix devshell built for default-features. I am now passing `--no-default-features` to cargo, and having it use our unified feature list rather than duplicating the unification inside cargo.
-
Without setting JEMALLOC_OVERRIDE, we end up linking to two different jemalloc builds. Once dynamically, as a transitive dependency through rocksdb, and a second time to the static jemalloc that tikv-jemalloc-sys builds.
-
