Signed-off-by: Jason Volk <jason@zemos.net>

Signed-off-by: Jason Volk <jason@zemos.net>

Signed-off-by: Jason Volk <jason@zemos.net>

Signed-off-by: Jason Volk <jason@zemos.net>

Signed-off-by: Jason Volk <jason@zemos.net>

Signed-off-by: Jason Volk <jason@zemos.net>

Signed-off-by: Jason Volk <jason@zemos.net>

Signed-off-by: strawberry <strawberry@puppygock.gay>

Signed-off-by: Jason Volk <jason@zemos.net>

Signed-off-by: Jason Volk <jason@zemos.net>

Signed-off-by: Jason Volk <jason@zemos.net>

Signed-off-by: Jason Volk <jason@zemos.net>

Signed-off-by: Jason Volk <jason@zemos.net>

Signed-off-by: Jason Volk <jason@zemos.net>

Signed-off-by: Jason Volk <jason@zemos.net>

Signed-off-by: Jason Volk <jason@zemos.net>

Signed-off-by: Jason Volk <jason@zemos.net>

Signed-off-by: Jason Volk <jason@zemos.net>

Signed-off-by: Jason Volk <jason@zemos.net>

Signed-off-by: Jason Volk <jason@zemos.net>

Signed-off-by: Jason Volk <jason@zemos.net>

Signed-off-by: Jason Volk <jason@zemos.net>

Signed-off-by: Jason Volk <jason@zemos.net>

Signed-off-by: Jason Volk <jason@zemos.net>

🥺 authored 9 months ago and 🥺 committed 9 months ago

Signed-off-by: strawberry <strawberry@puppygock.gay>

Matthias Ahouansou authored 9 months ago and 🥺 committed 9 months ago

Should make it safer to move the alias if the admin room broke on a public server.

Signed-off-by: strawberry <strawberry@puppygock.gay>

🥺 authored 9 months ago and 🥺 committed 9 months ago

Signed-off-by: strawberry <strawberry@puppygock.gay>

Matthias Ahouansou authored 9 months ago and 🥺 committed 9 months ago

Previously, anyone could remove any local alias, meaning that someone could re-route a popular alias elsewhere
Now, only the creator of the alias, users who can set canonical aliases for the room, server admins and the server user can delete aliases

added some additional changes/fixes to adapt to our codebase

Co-authored-by: strawberry <strawberry@puppygock.gay>
Signed-off-by: strawberry <strawberry@puppygock.gay>

Matthias Ahouansou authored 9 months ago and 🥺 committed 9 months ago

Should prevent some edge cases with a misconfigured admin room

Signed-off-by: strawberry <strawberry@puppygock.gay>

Benjamin Lee authored 9 months ago and 🥺 committed 9 months ago

Signed-off-by: strawberry <strawberry@puppygock.gay>

Benjamin Lee authored 9 months ago and 🥺 committed 9 months ago

bit of code dedupe as well

Co-authored-by: strawberry <strawberry@puppygock.gay>
Signed-off-by: strawberry <strawberry@puppygock.gay>

Benjamin Lee authored 9 months ago and 🥺 committed 9 months ago

This ensures that the tokenization algorithm will remain in sync between
querying, indexing, and deindexing. The existing code had slightly
different behavior for querying, because it did not discard words with
>50 bytes. This was inconsequential, because >50 byte tokens are never
present in the index.

Signed-off-by: strawberry <strawberry@puppygock.gay>

Benjamin Lee authored 9 months ago and 🥺 committed 9 months ago

The previous code would drop some events entirely if any events between
`skip` and `skip + limit` were not visible to the user. This would cause
the set of events skipped by the `skip(skip)` method to extend past
`skip` in the raw result set, because `skip(skip)` was being called
*after* filtering out invisible events.

This bug will become much more severe with a full filtering
implementation, because it will be more likely for events to be filtered
out. Currently, it is only possible to trigger with rooms that have
history visibility set to "invited" or "joined".

Signed-off-by: strawberry <strawberry@puppygock.gay>

Benjamin Lee authored 9 months ago and 🥺 committed 9 months ago

The previous code would fail to return next_batch if any of the events
in the window were not visible to the user. It would also return an
unnecessary next_batch when no more results are available if the total
number of results is exactly `skip + limit`.

This bug will become much more severe with a full filtering
implementation, because we will be more likely to trigger it by
filtering out events in a search call. Currently, it is only possible to
trigger with rooms that have history visibility set to "invited" or
"joined".

Signed-off-by: strawberry <strawberry@puppygock.gay>

🥺 authored 9 months ago and 🥺 committed 9 months ago

Signed-off-by: strawberry <strawberry@puppygock.gay>

Signed-off-by: strawberry <strawberry@puppygock.gay>

Signed-off-by: strawberry <strawberry@puppygock.gay>