bump rocksdb to v9.8.4, enable track_and_verify_wals_in_manifest by default

Signed-off-by: strawberry <strawberry@puppygock.gay>

Cargo.lock

@@ -3390,8 +3390,8 @@ dependencies = [
 
 [[package]]
 name = "rust-librocksdb-sys"
-version = "0.29.0+9.7.4"
-source = "git+https://github.com/girlbossceo/rust-rocksdb-zaidoon1?rev=e2b8853ee8839dc886e88fd751fe50ed1c27b47e#e2b8853ee8839dc886e88fd751fe50ed1c27b47e"
+version = "0.30.0+9.8.4"
+source = "git+https://github.com/girlbossceo/rust-rocksdb-zaidoon1?rev=3a9640a6b9173d24819c22a49487e31d20a2e59e#3a9640a6b9173d24819c22a49487e31d20a2e59e"
 dependencies = [
  "bindgen",
  "bzip2-sys",
@@ -3407,8 +3407,8 @@ dependencies = [
 
 [[package]]
 name = "rust-rocksdb"
-version = "0.33.0"
-source = "git+https://github.com/girlbossceo/rust-rocksdb-zaidoon1?rev=e2b8853ee8839dc886e88fd751fe50ed1c27b47e#e2b8853ee8839dc886e88fd751fe50ed1c27b47e"
+version = "0.34.0"
+source = "git+https://github.com/girlbossceo/rust-rocksdb-zaidoon1?rev=3a9640a6b9173d24819c22a49487e31d20a2e59e#3a9640a6b9173d24819c22a49487e31d20a2e59e"
 dependencies = [
  "libc",
  "rust-librocksdb-sys",

deps/rust-rocksdb/Cargo.toml

@@ -27,7 +27,7 @@ malloc-usable-size = ["rust-rocksdb/malloc-usable-size"]
 
 [dependencies.rust-rocksdb]
 git = "https://github.com/girlbossceo/rust-rocksdb-zaidoon1"
-rev = "e2b8853ee8839dc886e88fd751fe50ed1c27b47e"
+rev = "3a9640a6b9173d24819c22a49487e31d20a2e59e"
 #branch = "master"
 default-features = false
 

flake.lock

@@ -922,16 +922,16 @@
     "rocksdb": {
       "flake": false,
       "locked": {
-        "lastModified": 1731690620,
-        "narHash": "sha256-Xd4TJYqPERMJLXaGa6r6Ny1Wlw8Uy5Cyf/8q7nS58QM=",
+        "lastModified": 1733704887,
+        "narHash": "sha256-4ijNmXACyTJWKRcTdlgObdbOVm2oN3Zefg55/4UPIL0=",
         "owner": "girlbossceo",
         "repo": "rocksdb",
-        "rev": "292446aa2bc41699204d817a1e4b091679a886eb",
+        "rev": "9c656e58c9f969aea28f25b22bc52ea03109677a",
         "type": "github"
       },
       "original": {
         "owner": "girlbossceo",
-        "ref": "v9.7.4",
+        "ref": "v9.8.4",
         "repo": "rocksdb",
         "type": "github"
       }

flake.nix

@@ -9,7 +9,7 @@
     flake-utils.url = "github:numtide/flake-utils?ref=main";
     nix-filter.url = "github:numtide/nix-filter?ref=main";
     nixpkgs.url = "github:NixOS/nixpkgs?ref=nixpkgs-unstable";
-    rocksdb = { url = "github:girlbossceo/rocksdb?ref=v9.7.4"; flake = false; };
+    rocksdb = { url = "github:girlbossceo/rocksdb?ref=v9.8.4"; flake = false; };
     liburing = { url = "github:axboe/liburing?ref=master"; flake = false; };
   };
 

src/database/opts.rs

@@ -95,6 +95,12 @@ pub(crate) fn db_options(config: &Config, env: &mut Env, row_cache: &Cache, col_
 		4_u8..=u8::MAX => unimplemented!(),
 	});
 
+	// <https://github.com/facebook/rocksdb/wiki/Track-WAL-in-MANIFEST>
+	// "We recommend to set track_and_verify_wals_in_manifest to true for
+	// production, it has been enabled in production for the entire database cluster
+	// serving the social graph for all Meta apps."
+	opts.set_track_and_verify_wals_in_manifest(true);
+
 	opts.set_paranoid_checks(config.rocksdb_paranoid_file_checks);
 
 	opts.set_env(env);