Skip to content
Snippets Groups Projects
Commit 667db8e8 authored by 🥺's avatar 🥺 :transgender_flag: Committed by 🥺
Browse files

output error if sending to trusted key server failed

parent 935202ea
No related branches found
No related tags found
No related merge requests found
...@@ -1445,7 +1445,7 @@ async fn batch_request_signing_keys( ...@@ -1445,7 +1445,7 @@ async fn batch_request_signing_keys(
) -> Result<()> { ) -> Result<()> {
for server in services().globals.trusted_servers() { for server in services().globals.trusted_servers() {
info!("Asking batch signing keys from trusted server {}", server); info!("Asking batch signing keys from trusted server {}", server);
if let Ok(keys) = services() match services()
.sending .sending
.send_federation_request( .send_federation_request(
server, server,
...@@ -1455,35 +1455,39 @@ async fn batch_request_signing_keys( ...@@ -1455,35 +1455,39 @@ async fn batch_request_signing_keys(
) )
.await .await
{ {
debug!("Got signing keys: {:?}", keys); Ok(keys) => {
let mut pkm = pub_key_map.write().await; debug!("Got signing keys: {:?}", keys);
for k in keys.server_keys { let mut pkm = pub_key_map.write().await;
let k = match k.deserialize() { for k in keys.server_keys {
Ok(key) => key, let k = match k.deserialize() {
Err(e) => { Ok(key) => key,
warn!("Received error {e} while fetching keys from trusted server {server}"); Err(e) => {
warn!("{}", k.into_json()); warn!("Received error {e} while fetching keys from trusted server {server}");
continue; warn!("{}", k.into_json());
}, continue;
}; },
};
// TODO: Check signature from trusted server? // TODO: Check signature from trusted server?
servers.remove(&k.server_name); servers.remove(&k.server_name);
let result = services() let result = services()
.globals .globals
.add_signing_key(&k.server_name, k.clone())? .add_signing_key(&k.server_name, k.clone())?
.into_iter() .into_iter()
.map(|(k, v)| (k.to_string(), v.key)) .map(|(k, v)| (k.to_string(), v.key))
.collect::<BTreeMap<_, _>>(); .collect::<BTreeMap<_, _>>();
pkm.insert(k.server_name.to_string(), result); pkm.insert(k.server_name.to_string(), result);
} }
} else { },
warn!( Err(e) => {
"Failed sending batched key request to trusted key server {server} for the remote servers \ warn!(
{servers:?}" "Failed sending batched key request to trusted key server {server} for the remote servers \
); {:?}: {e}",
servers
);
},
} }
} }
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment