From feee8199734c9d8a18fa0be12fc5ec09ae140a3a Mon Sep 17 00:00:00 2001
From: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
Date: Mon, 13 Jan 2020 12:41:51 +0000
Subject: [PATCH] Fix exceptions on requests for non-ascii urls (#6682)
Fixes #6402
---
changelog.d/6682.bugfix | 2 ++
synapse/http/site.py | 2 +-
2 files changed, 3 insertions(+), 1 deletion(-)
create mode 100644 changelog.d/6682.bugfix
diff --git a/changelog.d/6682.bugfix b/changelog.d/6682.bugfix
new file mode 100644
index 0000000000..d48ea31477
--- /dev/null
+++ b/changelog.d/6682.bugfix
@@ -0,0 +1,2 @@
+Fix "CRITICAL" errors being logged when a request is received for a uri containing non-ascii characters.
+
diff --git a/synapse/http/site.py b/synapse/http/site.py
index 9f2d035fa0..911251c0bc 100644
--- a/synapse/http/site.py
+++ b/synapse/http/site.py
@@ -88,7 +88,7 @@ class SynapseRequest(Request):
def get_redacted_uri(self):
uri = self.uri
if isinstance(uri, bytes):
- uri = self.uri.decode("ascii")
+ uri = self.uri.decode("ascii", errors="replace")
return redact_uri(uri)
def get_method(self):
--
GitLab