From fe08db2713cb35e1424034d58d750ebdc52cedbc Mon Sep 17 00:00:00 2001
From: Erik Johnston <erik@matrix.org>
Date: Tue, 31 Jan 2017 15:21:32 +0000
Subject: [PATCH] Remove explicit < 400 check as apparently this is confusing
---
synapse/util/retryutils.py | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/synapse/util/retryutils.py b/synapse/util/retryutils.py
index 5c7fc1afb4..b94ae369cf 100644
--- a/synapse/util/retryutils.py
+++ b/synapse/util/retryutils.py
@@ -129,9 +129,7 @@ class RetryDestinationLimiter(object):
# APIs may expect to never received e.g. a 404. It's important to
# handle 404 as some remote servers will return a 404 when the HS
# has been decommissioned.
- if exc_val.code < 400:
- valid_err_code = True
- elif exc_val.code == 404 and self.backoff_on_404:
+ if exc_val.code == 404 and self.backoff_on_404:
valid_err_code = False
elif exc_val.code == 429:
# 429 is us being aggresively rate limited, so lets rate limit
--
GitLab