From f8f14ba466a18ee38827629b8e9ab2d5931e5713 Mon Sep 17 00:00:00 2001
From: Erik Johnston <erik@matrix.org>
Date: Tue, 26 Nov 2019 16:06:41 +0000
Subject: [PATCH] Don't construct a set
---
synapse/storage/data_stores/main/registration.py | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/synapse/storage/data_stores/main/registration.py b/synapse/storage/data_stores/main/registration.py
index c124bbb88b..0a3c1f0510 100644
--- a/synapse/storage/data_stores/main/registration.py
+++ b/synapse/storage/data_stores/main/registration.py
@@ -492,17 +492,14 @@ class RegistrationWorkerStore(SQLBaseStore):
regex = re.compile(r"^@(\d+):")
- found = set()
+ max_found = 0
for (user_id,) in txn:
match = regex.search(user_id)
if match:
- found.add(int(match.group(1)))
+ max_found = max(int(match.group(1)), max_found)
- if not found:
- return 1
-
- return max(found) + 1
+ return max_found + 1
return (
(
--
GitLab