From c7376cdfe3efe05942964efcdf8886d66342383c Mon Sep 17 00:00:00 2001
From: Erik Johnston <erik@matrix.org>
Date: Mon, 18 Nov 2019 17:10:16 +0000
Subject: [PATCH] Apply suggestions from code review
Co-Authored-By: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
Co-Authored-By: Brendan Abolivier <babolivier@matrix.org>
---
synapse/handlers/auth.py | 4 ++--
synapse/rest/client/v1/login.py | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/synapse/handlers/auth.py b/synapse/handlers/auth.py
index 20c62bd780..0955cf9dba 100644
--- a/synapse/handlers/auth.py
+++ b/synapse/handlers/auth.py
@@ -135,8 +135,8 @@ class AuthHandler(BaseHandler):
AuthError if the client has completed a login flow, and it gives
a different user to `requester`
- LimitExceededError if the ratelimiter's failed requests count for this
- user is too high too proceed
+ LimitExceededError if the ratelimiter's failed request count for this
+ user is too high to proceed
"""
diff --git a/synapse/rest/client/v1/login.py b/synapse/rest/client/v1/login.py
index abc210da57..f8d58afb29 100644
--- a/synapse/rest/client/v1/login.py
+++ b/synapse/rest/client/v1/login.py
@@ -397,7 +397,7 @@ class LoginRestServlet(RestServlet):
raise LoginError(401, "Invalid JWT", errcode=Codes.UNAUTHORIZED)
user_id = UserID(user, self.hs.hostname).to_string()
- result = yield self._complete_login(user_id, login_submission)
+ result = yield self._complete_login(user_id, login_submission, create_non_existant_users=True)
return result
--
GitLab