From 6850f8aea3482443dff1c330fb63f7ca8dde0025 Mon Sep 17 00:00:00 2001
From: Luke Barnard <luke@matrix.org>
Date: Thu, 5 Apr 2018 17:16:31 +0100
Subject: [PATCH] Get group_info from existing call to check_group_is_ours
---
synapse/groups/groups_server.py | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/synapse/groups/groups_server.py b/synapse/groups/groups_server.py
index 507ec232c5..1b516011d8 100644
--- a/synapse/groups/groups_server.py
+++ b/synapse/groups/groups_server.py
@@ -741,11 +741,7 @@ class GroupsServerHandler(object):
This will error if the group requires an invite/knock to join
"""
- yield self.check_group_is_ours(group_id, requester_user_id, and_exists=True)
-
- group_info = yield self.store.get_group(
- group_id,
- )
+ group_info = yield self.check_group_is_ours(group_id, requester_user_id, and_exists=True)
if group_info['join_policy'] != "open":
raise SynapseError(403, "Group is not publicly joinable")
--
GitLab