From 5d069291696c62c94d795506dd5a22a3dbd019e1 Mon Sep 17 00:00:00 2001
From: Mark Haines <mark.haines@matrix.org>
Date: Thu, 31 Mar 2016 15:09:09 +0100
Subject: [PATCH] Move the check for backfilled outside the for loop
---
synapse/storage/events.py | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/synapse/storage/events.py b/synapse/storage/events.py
index b5f9b3b900..83279d65fa 100644
--- a/synapse/storage/events.py
+++ b/synapse/storage/events.py
@@ -485,12 +485,12 @@ class EventsStore(SQLBaseStore):
],
)
- for event, _ in state_events_and_contexts:
- if backfilled:
- # Backfilled events come before the current state so shouldn't
- # clobber it.
- continue
+ if backfilled:
+ # Backfilled events come before the current state so we don't need
+ # to update the current state table
+ return
+ for event, _ in state_events_and_contexts:
if (not event.internal_metadata.is_invite_from_remote()
and event.internal_metadata.is_outlier()):
# Outlier events generally shouldn't clobber the current state.
--
GitLab