diff --git a/changelog.d/7930.feature b/changelog.d/7930.feature new file mode 100644 index 0000000000000000000000000000000000000000..a27e4812daa2ce57d76f8a2071194b4d9b0489f1 --- /dev/null +++ b/changelog.d/7930.feature @@ -0,0 +1 @@ +Abort federation requests where the client disconnects before the ratelimiter expires. diff --git a/synapse/federation/transport/server.py b/synapse/federation/transport/server.py index 24f7d4b3bcad147215daf5478a6950dbc9e1b134..5e111aa902694e990d1c37c63c9647506dbc6d9a 100644 --- a/synapse/federation/transport/server.py +++ b/synapse/federation/transport/server.py @@ -338,6 +338,12 @@ class BaseFederationServlet(object): if origin: with ratelimiter.ratelimit(origin) as d: await d + if request._disconnected: + logger.warning( + "client disconnected before we started processing " + "request" + ) + return -1, None response = await func( origin, content, request.args, *args, **kwargs )