From f3a7b2c7e4e2b77048e81ce6063b228cf490c84c Mon Sep 17 00:00:00 2001 From: Tulir Asokan <tulir@maunium.net> Date: Sun, 20 Jan 2019 00:17:37 +0200 Subject: [PATCH] Check error before response when logging in --- gitlab-auth.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/gitlab-auth.go b/gitlab-auth.go index a965d45..9b87d71 100644 --- a/gitlab-auth.go +++ b/gitlab-auth.go @@ -50,10 +50,10 @@ func loginGitlab(userID, token string) string { } user, resp, err := git.Users.CurrentUser() - if resp.StatusCode == 401 { - return fmt.Sprintf("Invalid access token!") - } else if err != nil { + if err != nil { return fmt.Sprintf("GitLab login failed: %s", err) + } else if resp.StatusCode == 401 { + return fmt.Sprintf("Invalid access token!") } gitlabTokens[userID] = token -- GitLab