From b1f4e6e4fc3d0cf5e10d6a79ef89abdcc9e63e8c Mon Sep 17 00:00:00 2001
From: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
Date: Thu, 1 Oct 2020 13:34:24 +0100
Subject: [PATCH] fix a logging error in thumbnailer (#8435)
Introduced in #8236
---
changelog.d/8435.bugfix | 1 +
synapse/rest/media/v1/media_repository.py | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
create mode 100644 changelog.d/8435.bugfix
diff --git a/changelog.d/8435.bugfix b/changelog.d/8435.bugfix
new file mode 100644
index 0000000000..6f04871015
--- /dev/null
+++ b/changelog.d/8435.bugfix
@@ -0,0 +1 @@
+Fix a longstanding bug where files that could not be thumbnailed would result in an Internal Server Error.
diff --git a/synapse/rest/media/v1/media_repository.py b/synapse/rest/media/v1/media_repository.py
index ae6822d6e7..e1192b47cd 100644
--- a/synapse/rest/media/v1/media_repository.py
+++ b/synapse/rest/media/v1/media_repository.py
@@ -637,7 +637,7 @@ class MediaRepository:
thumbnailer = Thumbnailer(input_path)
except ThumbnailError as e:
logger.warning(
- "Unable to generate thumbnails for remote media %s from %s using a method of %s and type of %s: %s",
+ "Unable to generate thumbnails for remote media %s from %s of type %s: %s",
media_id,
server_name,
media_type,
--
GitLab