diff --git a/synapse/handlers/_base.py b/synapse/handlers/_base.py index f141e92ce2ff66cb8480ac1e2ae5b4a5ec494fc4..b37c8be96467e2c87efb8459c73fddbeefa0fe7e 100644 --- a/synapse/handlers/_base.py +++ b/synapse/handlers/_base.py @@ -35,7 +35,7 @@ class BaseRoomHandler(BaseHandler): extra_users=[]): snapshot.fill_out_prev_events(event) - store_id = yield self.store.persist_event(event) + yield self.store.persist_event(event) destinations = set(extra_destinations) # Send a PDU to all hosts who have joined the room. diff --git a/synapse/handlers/federation.py b/synapse/handlers/federation.py index 220dbbb3a9db1cd596342de90feb80eaa3da32bd..606e1f18176d4ccf9ff1fc8c4a30b8728f39a87c 100644 --- a/synapse/handlers/federation.py +++ b/synapse/handlers/federation.py @@ -22,8 +22,6 @@ from synapse.api.constants import Membership from synapse.util.logutils import log_function from synapse.federation.pdu_codec import PduCodec -from synapse.api.errors import AuthError - from twisted.internet import defer import logging @@ -146,7 +144,7 @@ class FederationHandler(BaseHandler): else: with (yield self.room_lock.lock(event.room_id)): - store_id = yield self.store.persist_event(event, backfilled) + yield self.store.persist_event(event, backfilled) room = yield self.store.get_room(event.room_id) diff --git a/synapse/handlers/typing.py b/synapse/handlers/typing.py index 9d38a7336e1edc9f582a106b255e7d92812cb6ed..9fab0ff37c7d5868350f4e1ca525d49fe06d8045 100644 --- a/synapse/handlers/typing.py +++ b/synapse/handlers/typing.py @@ -17,11 +17,12 @@ from twisted.internet import defer from ._base import BaseHandler +from synapse.api.errors import SynapseError, AuthError + import logging from collections import namedtuple - logger = logging.getLogger(__name__) diff --git a/synapse/server.py b/synapse/server.py index ade8dc6c15d9eb24a377cce1d740c5f72eae2fb5..3e72b2bcd5480df57bc4d1959ee4b83913875a2f 100644 --- a/synapse/server.py +++ b/synapse/server.py @@ -126,11 +126,6 @@ class BaseHomeServer(object): object.""" return UserID.from_string(s, hs=self) - def parse_roomid(self, s): - """Parse the string given by 's' as a Room ID and return a RoomID - object.""" - return RoomID.from_string(s, hs=self) - def parse_roomalias(self, s): """Parse the string given by 's' as a Room Alias and return a RoomAlias object."""