From 559c51debcf5402cd5999aa1afb854b34e9de363 Mon Sep 17 00:00:00 2001
From: Mark Haines <mark.haines@matrix.org>
Date: Mon, 10 Aug 2015 14:07:08 +0100
Subject: [PATCH] Use TypeError instead of ValueError and give a nicer error
mesasge when someone calls Cache.invalidate with the wrong type.
---
synapse/storage/_base.py | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/synapse/storage/_base.py b/synapse/storage/_base.py
index e76ee2779a..73eea157a4 100644
--- a/synapse/storage/_base.py
+++ b/synapse/storage/_base.py
@@ -116,7 +116,9 @@ class Cache(object):
def invalidate(self, key):
self.check_thread()
if not isinstance(key, tuple):
- raise ValueError("keyargs must be a tuple.")
+ raise TypeError(
+ "The cache key must be a tuple not %r" % (type(key),)
+ )
# Increment the sequence number so that any SELECT statements that
# raced with the INSERT don't update the cache (SYN-369)
--
GitLab