From 09cbff174a01757d10107b7960972a484153323e Mon Sep 17 00:00:00 2001
From: Kegan Dougal <kegan@matrix.org>
Date: Tue, 31 Mar 2015 16:43:49 +0100
Subject: [PATCH] Fix thinko whereby events *for the AS specifically* were not
passed on.
This was caused by not explicitly checking the service.sender field. This
has now been fixed and a regression test has been added.
---
synapse/appservice/__init__.py | 5 ++++-
tests/appservice/test_appservice.py | 13 +++++++++++++
2 files changed, 17 insertions(+), 1 deletion(-)
diff --git a/synapse/appservice/__init__.py b/synapse/appservice/__init__.py
index c60db16b74..4a6cdbc2be 100644
--- a/synapse/appservice/__init__.py
+++ b/synapse/appservice/__init__.py
@@ -199,7 +199,10 @@ class ApplicationService(object):
return self._matches_user(event, member_list)
def is_interested_in_user(self, user_id):
- return self._matches_regex(user_id, ApplicationService.NS_USERS)
+ return (
+ self._matches_regex(user_id, ApplicationService.NS_USERS)
+ or user_id == self.sender
+ )
def is_interested_in_alias(self, alias):
return self._matches_regex(alias, ApplicationService.NS_ALIASES)
diff --git a/tests/appservice/test_appservice.py b/tests/appservice/test_appservice.py
index eb7becf725..62149d6902 100644
--- a/tests/appservice/test_appservice.py
+++ b/tests/appservice/test_appservice.py
@@ -199,6 +199,19 @@ class ApplicationServiceTestCase(unittest.TestCase):
aliases_for_event=["#xmpp_barfoo:matrix.org"]
))
+ def test_interested_in_self(self):
+ # make sure invites get through
+ self.service.sender = "@appservice:name"
+ self.service.namespaces[ApplicationService.NS_USERS].append(
+ _regex("@irc_.*")
+ )
+ self.event.type = "m.room.member"
+ self.event.content = {
+ "membership": "invite"
+ }
+ self.event.state_key = self.service.sender
+ self.assertTrue(self.service.is_interested(self.event))
+
def test_member_list_match(self):
self.service.namespaces[ApplicationService.NS_USERS].append(
_regex("@irc_.*")
--
GitLab